-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-Picking Map Spawners #563
Open
southbridge-fur
wants to merge
9
commits into
Fansana:master
Choose a base branch
from
southbridge-fur:map-spawners
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Entity table code * entity table examples * fix dat shit * access * tests tests tests * sloth review
Infer type for EntSelector.cs
* adds more spawners * make it WORK. ooo.. a. e * fix * outerclothing capitalization * prototype fix * flashbang fix
* Added spanwers and modified others * adjusted values to be more in line with what I want * this comment may have caused that test fail * oh my god another typo * Modified door crate to be engineering flavored * reduced the pride vendor odds Webedit lmao
…oved from the game prior to this but is still upstream?
Memeji
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea itself is good for me, just needs a look over the code.
It does look like at least some of these are in EE already, just not pulled to Floof yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes: C#
Changes any cs files
Changes: Sprite
Changes any png or json in an RSI
Changes: YML
Changes any yml files
Status: Needs Review
Someone please review this
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picking several map spawners and spawner changes from upstream.
This is the first of many PRs I'm gonna open porting things from upstream to here.
This is mostly to provide quality of life in this case, as I really like these spawners and would like to use them in my map.
I will also take some time to add them to other maps in rotation.
Cherry picked PRs
The two Amber station-specific PRs are only partial cherry-picks, as to not include the changes to the map. I'll be creating a PR in the future with the map after I've ported everything I care about.
Some of the PRs I've cherry picked from upstream are my own, so it may be a little difficult to follow unfortunately.
I'll open another PR later to also add some more items to these loot pools for Floof.
Media
Yep they all work pretty well
Changelog
No CL, this is entirely a setup for some mapping changes in the future though!