Cherry Picked Device Linking Fixes #591
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix DeviceLinkSinkComponent not updating sources on shutdown * Log error * Misc link changes & fixes * Fix core
southbridge-fur
requested review from
Fansana,
Memeji,
FoxxoTrystan and
Mnemotechnician
as code owners
github-actions
bot
added
Status: Needs Review
Fix shouldn't break anythingTM.
github-actions
bot
added
the
Changes: Map
southbridge-fur
force-pushed
the
cherry-pick-link-fix
branch
from
cd06570 to
5eb6ec2
Compare
|
I am stupid and accidentally pushed my Glacier changes to this branch and had to force push to remove them |
Memeji
approved these changes
Mar 1, 2025
Mnemotechnician
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picked
This resolves a lot of various bugs with device networks, including the most important one which was preventing me from linking doors to buttons.
Media
it works now
Changelog
🆑 Southbridge