Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Craftable Bonfire #84

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Add Craftable Bonfire #84

merged 2 commits into from
Aug 7, 2024

Conversation

Fansana
Copy link
Owner

@Fansana Fansana commented Aug 7, 2024

Description

This PR makes bonfires craftable

Changelog

🆑

  • add: make bonfires craftable

@Fansana Fansana requested a review from FoxxoTrystan as a code owner August 7, 2024 11:52
@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: YML Changes any yml files labels Aug 7, 2024
@Fansana Fansana added the Priority: 3-Low Should be resolved at some point label Aug 7, 2024
FoxxoTrystan
FoxxoTrystan requested changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue i found is the one i mentioned.

I have not tested it and did the correct test i wanted, il do that after scubadiving.

Resources/Prototypes/Entities/Structures/Decoration/bonfire.yml Show resolved Hide resolved
@Fansana Fansana merged commit abf03fa into master Aug 7, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoxxoTrystan FoxxoTrystan FoxxoTrystan requested changes

Assignees
No one assigned
Labels
Changes: YML Changes any yml files Priority: 3-Low Should be resolved at some point Status: Needs Review Someone please review this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fansana @FoxxoTrystan