Use multiprocessing.get_all_start_methods() in test_async_with_dynamically_registered_env #1222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Windows, I was obtaining these test failures:
This is happening as
fork
andforkserver
are not supported on Windows, and other platforms may have similar limitations. To avoid such test failures, I modified thetest_async_with_dynamically_registered_env
parametrization to usemultiprocessing.get_all_start_methods()
instead of hardcoding["spawn", "fork", "forkserver"]
on all platforms.Type of change
Please delete options that are not relevant.
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)