Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multiprocessing.get_all_start_methods() in test_async_with_dynamically_registered_env #1222

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Oct 20, 2024

Description

On Windows, I was obtaining these test failures:

2024-10-20T14:32:51.8042643Z FAILED tests/envs/registration/test_make_vec.py::test_async_with_dynamically_registered_env[fork] - ValueError: cannot find context for 'fork'
2024-10-20T14:32:51.8043645Z FAILED tests/envs/registration/test_make_vec.py::test_async_with_dynamically_registered_env[forkserver] - ValueError: cannot find context for 'forkserver'

This is happening as fork and forkserver are not supported on Windows, and other platforms may have similar limitations. To avoid such test failures, I modified the test_async_with_dynamically_registered_env parametrization to use multiprocessing.get_all_start_methods() instead of hardcoding ["spawn", "fork", "forkserver"] on all platforms.

Type of change

Please delete options that are not relevant.

  • Documentation only change (no code changed)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit af367bb into Farama-Foundation:main Oct 20, 2024
13 checks passed
@traversaro
Copy link
Contributor Author

Ah, sorry for typo and thanks for the fast review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants