Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MujocoEnv refactor remove single line function _reset_simulation() #960

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

Kallinteris-Andreas
Copy link
Collaborator

@Kallinteris-Andreas Kallinteris-Andreas commented Mar 11, 2024

Description

removes the _reset_simulation() to clean up the MujocoEnv code

Note: _reset_simulation() is not being changed in Robotics or Meta, so it should be an issue

Validation: the test/envs/mujoco is enough

Type of change

  • Refactor
  • Documentation only change (no code changed)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Kallinteris-Andreas Kallinteris-Andreas marked this pull request as ready for review March 11, 2024 18:53
@Kallinteris-Andreas Kallinteris-Andreas changed the title MuJoCo refactor remove single line function _reset_simulation() MujocoEnv refactor remove single line function _reset_simulation() Mar 11, 2024
@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 087a5dc into main Mar 12, 2024
16 checks passed
@Kallinteris-Andreas Kallinteris-Andreas deleted the Kallinteris-Andreas-patch-1 branch March 23, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants