Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lunar lander step to match performance with Gymnasium #91

Conversation

pseudo-rnd-thoughts
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts commented Mar 14, 2024

#89 found that mo-lunar-lander had a couple of differences with Gymnasium that caused performance issues.
However, testing the updated version improved performance but still did not match
Therefore, this PR, copy and pasted the Gymnasium version reverting changes that related to the reward vector.
As a result, the mo version now matches step fps (on my laptop)

from gymnasium.utils.performance import benchmark_step
import mo_gymnasium

env = mo_gymnasium.make("LunarLander-v2")
mo_env = mo_gymnasium.make("mo-lunar-lander-v2")

print(f'env benchmark - {benchmark_step(env, target_duration=15)}')  # 16997.796487754913 
print(f'mo-env benchmark - {benchmark_step(mo_env, target_duration=15)}')  # 15513.081151435932

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 85a2215 into Farama-Foundation:main Mar 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants