Add Room Size Customization to MiniGrid MultiRoom Environment #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
BartekCupial
force-pushed
the
configurable_multiroom
branch
from
f1c9b42 to
9177e8b
Compare
pseudo-rnd-thoughts
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces the ability to customize the size of rooms within the MiniGrid MultiRoom environment. Previously, the room size was fixed, but with this change, users can now specify the width and height of the rooms when creating an environment. The default room size remains unchanged, ensuring backward compatibility for existing implementations.
Changes:
Motivation:
This enhancement is crucial for integrating MiniGrid environments into MiniHack, which currently encounters errors when environments exceed the dimensions of the NetHack grid. By allowing room size adjustments, this PR facilitates seamless integration and expands the usability of MiniGrid within the MiniHack framework.
Link to PR in MiniHack: #106