refactored matrixreal and sigp methods #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dryuri92
reviewed
Dec 8, 2020
src/matrix.cpp
Outdated
Comment on lines
78
to
79
| xt::xarray<double> DecayMatrix::get_matrix_real(Chain& chain, | ||
| const Materials& mat, std::string matrix_kind) { |
There was a problem hiding this comment.
Передавать целую строку в качестве параметра?, если разница только в том, что в итерационном методе ты зануляешь диагональ? Может при вызове matrix_real вызвать функцию и добавить цикл для обнуления диагонали
src/matrix.cpp
Outdated
| @@ -169,7 +177,7 @@ xt::xarray<double> IterMatrix::matrixdev(Chain& chain, | |||
| for (size_t i = 0; i < NN; i++) { | |||
| std::copy(&this->data_[i][0], &this->data_[i][NN], | |||
| (result.begin() + i * NN)); | |||
| result(i, i) = 0.0; | |||
| result(i, i) = 0.0; // ------------------ | |||
There was a problem hiding this comment.
А здесь комментарий к чему?
ivanbukhtiyarov
force-pushed
the
dev_ivan
branch
from
1fa9cdc to
121cfa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.