Add ErrorReportConfiguration
#1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JooHyukKim
commented
Jul 27, 2023
| * | ||
| * @since 2.16 | ||
| */ | ||
| public class ErrorReportConfigurationTest |
There was a problem hiding this comment.
This is unit-test.
All the tests in the original PR #1043 had JsonFactory, IOContext, etc in scope, so they will be added later along the way.
| private static ErrorReportConfiguration DEFAULT = | ||
| new ErrorReportConfiguration(DEFAULT_MAX_ERROR_TOKEN_LENGTH, DEFAULT_MAX_RAW_CONTENT_LENGTH); | ||
|
|
||
| public static void overrideDefaultErrorReportConfiguration(final ErrorReportConfiguration errorReportConfiguration) { |
There was a problem hiding this comment.
Could you copy Javadoc from matching method in StreamWriteConstaints, warning against use of this method?
In general it should not be used and specifically libraries should not change global defaults, ever.
There was a problem hiding this comment.
Or actually I can do this.
cowtowncoder
approved these changes
Jul 29, 2023
cowtowncoder
changed the title
ErrorReportConfigurationErrorReportConfiguration
cowtowncoder
added a commit
that referenced
this pull request
Jul 29, 2023
|
Thank you @JooHyukKim ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #1066