Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test issue 4741 #4743

Merged
merged 1 commit into from
Oct 16, 2024
Merged

test issue 4741 #4743

merged 1 commit into from
Oct 16, 2024

Conversation

pjfanning
Copy link
Member

@pjfanning pjfanning commented Oct 9, 2024

see #4741

This test passes in 2.17 but fails in 2.18. Note that the 2.18 branch needs @Test annotations (Junit 4) while 2.17 uses Junit 3 style.

@pjfanning pjfanning marked this pull request as draft October 9, 2024 12:24
make test better match issue
@pjfanning pjfanning changed the title [NOT FOR MERGE] test issue 4741 test issue 4741 Oct 9, 2024
@pjfanning pjfanning marked this pull request as ready for review October 9, 2024 12:35
@cowtowncoder
Copy link
Member

Ok makes sense.

Quick note: JUnit4 vs JUNit 5 (not 3 and 4).

@pjfanning
Copy link
Member Author

@cowtowncoder tests where the methods needed 'test' as the prefix of the method name - that is junit 3. Junit 4 brought in @Test annotations. Junit 5 was the switchover to Jupiter but still has @Test annotations.

The code in this PR uses 'test' as the prefix of the method name to keep with the existing style in that class (in 2.17). The class changed in 2.18 and is now, I guess, junit 5 / jupiter style.

@cowtowncoder cowtowncoder merged commit c8e577d into FasterXML:2.17 Oct 16, 2024
6 checks passed
@cowtowncoder
Copy link
Member

@pjfanning Ok, yes, conceptually JUnit 3 tests. Actual JUnit version being used is/was JUnit 4 until 2.18 conversion to JUnit 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants