Regression fix for #4741 Include.NON_DEFAULT setting used on POJO, empty values are not included in json if default is null
#4744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix and test Delete GoodTest.java
1 task
JooHyukKim
changed the title
Include.NON_DEFAULT setting used on POJO, empty values are not included in json if default is null
| valueToSuppress = BeanPropertyWriter.MARKER_FOR_EMPTY; | ||
| // [databind#4471] Different behavior when Include.NON_DEFAULT | ||
| // setting is used on POJO vs global setting, as per documentation. | ||
| if (!_useRealPropertyDefaults) { |
There was a problem hiding this comment.
Instead of re-checking configuration settings, let's rely on "_useRealPropertyDefaults" which means that POJO settings are in use (not global-, per-type or property)?
cowtowncoder
approved these changes
Oct 16, 2024
|
@JooHyukKim I figured out a simpler check which I think works. But wanted to ask WDYT before merging. All tests pass which is good. |
|
I like the simpler check 🙏🏼 LGTM! @cowtowncoder |
|
@JooHyukKim Thank you for taking a lead on this! I'll go ahead and merge soon. |
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
demonstrates "possible" solution that resolves #4741