-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1484: change MapperFeature.DEFAULT_VIEW_INCLUSION
default to false
#4885
base: master
Are you sure you want to change the base?
Fix #1484: change MapperFeature.DEFAULT_VIEW_INCLUSION
default to false
#4885
Conversation
Ok this is gnarly -- about dozen test fails. Half are due to legit change (test expecting default inclusion), can just enforce "old" defaults for tests. But the rest (6 for |
Down to 0 failures in 2.19, 2 in 3.0, getting there. But also realizing that changing the default prevents "vanilla" processing and requires additional Active View checks -- so there is basically some overhead, both for serialization AND deserialization side. So need to do some performance verification and consider this aspect wrt defaults. :-/ |
Fixed the underlying real issue indicated by failures. So in theory this could be merged. |
No description provided.