Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1484: change MapperFeature.DEFAULT_VIEW_INCLUSION default to false #4885

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

cowtowncoder
Copy link
Member

No description provided.

@cowtowncoder
Copy link
Member Author

Ok this is gnarly -- about dozen test fails. Half are due to legit change (test expecting default inclusion), can just enforce "old" defaults for tests. But the rest (6 for 3.0, 5 for 2.x if I test it there) seem to be bugs in how the new setting is handled -- affects non-View enabled cases which should not be affected at all.

@cowtowncoder
Copy link
Member Author

Down to 0 failures in 2.19, 2 in 3.0, getting there.

But also realizing that changing the default prevents "vanilla" processing and requires additional Active View checks -- so there is basically some overhead, both for serialization AND deserialization side. So need to do some performance verification and consider this aspect wrt defaults. :-/

@cowtowncoder
Copy link
Member Author

Fixed the underlying real issue indicated by failures. So in theory this could be merged.
But need to decide whether possible performance aspect is worth worrying about or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant