Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] refactor Github Actions Used for FedML-AI/FedML CI #2180

Open
wants to merge 69 commits into
base: alexleung/dev_v070_for_refactor
Choose a base branch
from

Conversation

Qigemingziba
Copy link

WIP

Qigemingziba and others added 30 commits June 6, 2024 18:24
…vity

[Deploy] Report worker's connectivity when it finished.
…iner-deployment

[Deploy] Remove unnecessary logic
Copy link

gitguardian bot commented Jun 18, 2024

⚠️ GitGuardian has uncovered 24 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Generic High Entropy Secret 008266f devops/dockerfile/github-action-runner/DockerfileWx View secret
- Generic High Entropy Secret e25ad75 devops/dockerfile/github-action-runner/DockerfileLight View secret
- Generic High Entropy Secret c4ec02d devops/dockerfile/github-action-runner/Dockerfile View secret
- Generic High Entropy Secret ea9320b devops/dockerfile/github-action-runner/Dockerfile View secret
- Generic High Entropy Secret c4ec02d devops/dockerfile/github-action-runner/DockerfileLight View secret
- Generic High Entropy Secret 742862f devops/dockerfile/github-action-runner/DockerfileLight View secret
- Generic High Entropy Secret f3fa51b devops/dockerfile/github-action-runner/Dockerfile View secret
- Generic High Entropy Secret 11ab658 devops/dockerfile/github-action-runner/Dockerfile View secret
- Generic High Entropy Secret 742862f devops/dockerfile/github-action-runner/Dockerfile View secret
5692101 Triggered Generic High Entropy Secret 1275034 python/fedml/computing/scheduler/model_scheduler/device_model_deployment.py View secret
5692101 Triggered Generic High Entropy Secret 3fbaaee python/fedml/computing/scheduler/model_scheduler/device_model_deployment.py View secret
5692101 Triggered Generic High Entropy Secret f3fa51b python/fedml/computing/scheduler/model_scheduler/device_model_deployment.py View secret
- Generic CLI Secret 11ab658 devops/dockerfile/github-action-runner/WindowsDockerfile View secret
- Generic CLI Secret ea9320b devops/dockerfile/github-action-runner/WindowsDockerfile View secret
- Generic CLI Secret f3fa51b devops/dockerfile/github-action-runner/WindowsDockerfile View secret
9453265 Triggered Generic High Entropy Secret ea9320b python/tests/test_train/test_train.py View secret
9453265 Triggered Generic High Entropy Secret ea9320b python/fedml/api/api_test.py View secret
9453265 Triggered Generic High Entropy Secret f3fa51b python/fedml/api/api_test.py View secret
- Generic High Entropy Secret e25ad75 devops/dockerfile/github-action-runner/DockerfileLight View secret
- Generic High Entropy Secret 295ca57 devops/dockerfile/github-action-runner/DockerfileLight View secret
- Generic High Entropy Secret c4ec02d devops/dockerfile/github-action-runner/DockerfileLight View secret
- Generic High Entropy Secret 295ca57 devops/dockerfile/github-action-runner/DockerfileLight View secret
5692101 Triggered Generic High Entropy Secret 8530973 python/fedml/computing/scheduler/model_scheduler/device_model_deployment.py View secret
5692101 Triggered Generic High Entropy Secret 23d88fc python/fedml/computing/scheduler/model_scheduler/device_model_deployment.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants