Daily files config #179
Merged
Daily files config #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the `daily-notes.json` file was being parsed into a `HashMap<String, String>`. However, the deserialization was failing because on of the fields in that file is `autorun` which is a boolean. So the deserialization failed and the defaults were being returned instead of whatever was set in the obsidian config.
|
Hey! Thank you so much. This looks really helpful. I will get this merged by next week |
emilioziniades
force-pushed
the
daily-files-config
branch
from
70f9eeb to
f9145d3
Compare
|
Thank you so much! Also, big things ahead... #175 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, this is a great tool and I'm really excited to use it to interact with my obsidian vault from neovim. Thanks for all your work.
I noticed that moxide was not respecting my obsidian config for my daily notes folder. After digging in the code, I found the issue and made a fix. See the commit message for more details but the gist is that the deserialization of
daily-notes.jsoninto aHashMap<String, String>was failing. I also added unit tests for this behaviour.