-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer pendingUrl than url. #2067
base: master
Are you sure you want to change the base?
Conversation
I added a fix for showing failed resources correctly if tab is loading. |
This will fix #2082 |
@FelisCatus Are you still maintaining this project? I found it's inactive for a long time. If I don't get any response in a month, I will recreate a new extension that fork this one. |
I suspended to create a new distribution, I have mentioned the details at #2187 (in Chinese). |
@PMExtra There's a problem with this PR. I use an HTTPS proxy that needs authentication. For some reason, when I start a new tab and enter a URL, I will get a prompt to enter the username and password for authentication, despite having already set them inside SwitchyOmega options. I can simply press "Sign In" without typing any data, and the page will continue to work. I can even refresh the tab afterwards, and I will no longer get the authentication prompt. But it could be annoying every time you open a new tab. :( |
@PMExtra Hmmm, perhaps I was wrong. it looks like the authentication prompt appears without the PR applied. Perhaps Google is enforcing their new Manifest V3?! 🤔 |
What does this PR do?
Get url from
tab.pendingUrl
while tab is loading.It's useful when we access an url that unreachable by current proxy.
Formerly, we have to waiting for the page loading failed... It may spent tens of seconds or more. Then we can view the host at the SwitchyOmega popup.
Now, we can get the host immediately and we can set the temporary rule, the rule will effect immediately too and auto reload the tab with the pendingUrl.
Compatibility
This feature is works in Chrome 79+
(because of
pendingUrl
is added since that, reference https://developer.chrome.com/extensions/tabs#property-Tab-pendingUrl)But it won't break the original behavior in old versions.