Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in plasticity example #1052

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

Niel-77
Copy link
Contributor

@Niel-77 Niel-77 commented Aug 29, 2024

Spelling error correction

Spelling error correction
@Niel-77 Niel-77 closed this Aug 29, 2024
@Niel-77 Niel-77 reopened this Aug 29, 2024
Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I wonder if this would have been caught by #865 (@KnutAM).

@fredrikekre fredrikekre changed the title Update plasticity.jl Fix a typo in plasticity example Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.67%. Comparing base (fee40c5) to head (60d27e4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1052   +/-   ##
=======================================
  Coverage   93.67%   93.67%           
=======================================
  Files          39       39           
  Lines        6004     6004           
=======================================
  Hits         5624     5624           
  Misses        380      380           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredrikekre fredrikekre merged commit 241d181 into Ferrite-FEM:master Aug 29, 2024
18 checks passed
@KnutAM
Copy link
Member

KnutAM commented Aug 29, 2024

Unfortunately not since its not in the typos list. However, "Deadling" is aparently a music album...
But maybe sufficiently uncommon that one could propose adding deadling -> dealing here.

@KnutAM
Copy link
Member

KnutAM commented Aug 29, 2024

But updated to the master branch, and a few new spelling mistakes are found if someone wants to make a correction PR: https://github.com/Ferrite-FEM/Ferrite.jl/actions/runs/10614441410/job/29420362633?pr=865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants