Simplify initialization of types for N, dNdx, and dNdξ
#858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #858 +/- ##
==========================================
- Coverage 93.28% 93.27% -0.01%
==========================================
Files 36 36
Lines 5228 5222 -6
==========================================
- Hits 4877 4871 -6
Misses 351 351 ☔ View full report in Codecov by Sentry. |
termi-official
approved these changes
Dec 7, 2023
KnutAM
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
I think this can be merged as is.
The MixedTensor support is still some time in the future, and this is just an internal change to improve readability - I think this is much better than my solution.
(Hope I got the alignment right for the suggested help comments, hard to see in the web-browser)
This patch simplifies the initialization of types for `N`, `dNdx`, and `dNdξ` used in the `FunctionValues` constructor. The change in LOC isn't significant but I think it is easier to follow when there are no auxiliary types and when they are grouped by "case" instead of function name. Fixes #857.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch simplifies the initialization of types for
N,dNdx, anddNdξused in theFunctionValuesconstructor. The change in LOC isn't significant but I think it is easier to follow when there are no auxiliary types and when they are grouped by "case" instead of function name. Fixes #857.