Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delete nested components in build public command #200

Merged
merged 7 commits into from
Jul 10, 2024
Merged

fix: delete nested components in build public command #200

merged 7 commits into from
Jul 10, 2024

Conversation

CBeck-96
Copy link
Collaborator

Nested components of a deleted component will now also be removed from the SBOM.

closes #151

depends on #196

@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request unittests labels Jun 10, 2024
@CBeck-96 CBeck-96 changed the title Fix: build public incorrectly deletes nested components fix: build public incorrectly deletes nested components Jun 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 10, 2024 •
edited
Loading

Coverage

Coverage Report •
FileStmtsMissCoverMissing
build_public_bom.py670100% 
TOTAL16889194% 

Tests Skipped Failures Errors Time
298 2 💤 0 ❌ 0 🔥 4.995s ⏱️

@CBeck-96 CBeck-96 requested a review from italvi June 10, 2024 14:38
@italvi italvi requested a review from mmarseu June 26, 2024 06:00
mmarseu
mmarseu previously approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@mmarseu mmarseu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As requested, I tested the changes without reviewing the code. LGTM.

@CBeck-96 CBeck-96 mentioned this pull request Jun 28, 2024
Closed
@mmarseu mmarseu mentioned this pull request Jul 2, 2024
Merged
5 tasks
@CBeck-96 CBeck-96 force-pushed the 151-build-public-incorrectly-deletes-nested-components branch from 535cdf8 to 295abef Compare July 5, 2024 13:23
@CBeck-96 CBeck-96 requested a review from mmarseu July 5, 2024 15:04
mmarseu
mmarseu approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@mmarseu mmarseu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@italvi italvi changed the title fix: build public incorrectly deletes nested components fix: delete nested components in build public command Jul 10, 2024
@italvi italvi merged commit e8264fa into main Jul 10, 2024
5 checks passed
@italvi italvi deleted the 151-build-public-incorrectly-deletes-nested-components branch July 10, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmarseu mmarseu mmarseu approved these changes

@italvi italvi italvi approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request unittests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build-public incorrectly deletes nested components
3 participants
@CBeck-96 @mmarseu @italvi