-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: configure mypy to strict mode #339
Conversation
d7b46f5
to
677e422
Compare
Coverage Report •
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the type of the PR to "refactor" as you changed the code but only the style, also adjust the mypy config in the .pre-commit-config.yaml
, i.e.
- repo: https://github.com/pre-commit/mirrors-mypy
rev: "v1.13.0"
hooks:
- id: mypy
# List type stub dependencies explicitly, as --install-types should be avoided as per
# https://github.com/pre-commit/mirrors-mypy/blob/main/README.md
additional_dependencies:
- types-python-dateutil==2.9.0.20241003
- typing-extensions==4.12.2
- types-jsonschema==4.23.0.20240813
- cyclonedx-python-lib==8.5.0
- univers==30.12.1
- charset-normalizer==3.4.0
- natsort==8.4.0
- docstring-parser==0.16
files: "^cdxev/.*\\.py$"
args: ["--config-file", "pyproject.toml"]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tried it locally and the commit hook for mypy works, too.
closes #11
Some errors are excluded, since they will be fixed by transitioning to the cdx python lib