Merge pull request #542 from Financial-Times/node-20

Add support for Node.js 20
Financial-Times · Jan 17, 2024 · 3dd3bf5 · 3dd3bf5
2 parents 1956492 + bb8b7b1
commit 3dd3bf5
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 6 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -4,6 +4,9 @@ orbs:
   tool-kit: financial-times/dotcom-tool-kit@4
 executors:
   node:
+    docker:
+      - image: cimg/node:20.11
+  node18_19:
     docker:
       - image: cimg/node:18.19
   node16_20:
@@ -43,6 +46,7 @@ workflows:
             parameters:
               executor:
                 - node
+                - node18_19
                 - node16_20
           filters:
             tags:
@@ -55,6 +59,7 @@ workflows:
             parameters:
               executor:
                 - node
+                - node18_19
                 - node16_20
           filters:
             tags:
@@ -67,6 +72,7 @@ workflows:
             parameters:
               executor:
                 - node
+                - node18_19
                 - node16_20
           filters:
             tags:
@@ -101,6 +107,7 @@ workflows:
             parameters:
               executor:
                 - node
+                - node18_19
                 - node16_20
       - tool-kit/build:
           name: tool-kit/build-<< matrix.executor >>
@@ -110,6 +117,7 @@ workflows:
             parameters:
               executor:
                 - node
+                - node18_19
                 - node16_20
       - tool-kit/test:
           name: tool-kit/test-<< matrix.executor >>
@@ -119,4 +127,5 @@ workflows:
             parameters:
               executor:
                 - node
+                - node18_19
                 - node16_20
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-16
+20
diff --git a/.toolkitrc.yml b/.toolkitrc.yml
@@ -12,5 +12,6 @@ hooks:
 options:
   '@dotcom-tool-kit/circleci':
     nodeVersion:
+      - '20.11'
       - '18.19'
       - '16.20'
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -29,8 +29,8 @@
     "supertest": "^6.3.3"
   },
   "engines": {
-    "node": "16.x || 18.x",
-    "npm": "7.x || 8.x || 9.x"
+    "node": "16.x || 18.x || 20.x",
+    "npm": "7.x || 8.x || 9.x || 10.x"
   },
   "scripts": {
     "prepare": "npx snyk protect || npx snyk protect -d || true",
@@ -45,6 +45,6 @@
     }
   },
   "volta": {
-    "node": "18.16.0"
+    "node": "20.11.0"
   }
 }