-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invitation #135
Open
RomainGuarinoni
wants to merge
21
commits into
main
Choose a base branch
from
59-change-group-invitation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Invitation #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
RomainGuarinoni
force-pushed
the
59-change-group-invitation
branch
from
March 25, 2022 17:18
8b1017e
to
fe2eeaa
Compare
RomainGuarinoni
force-pushed
the
59-change-group-invitation
branch
from
March 28, 2022 12:17
fe2eeaa
to
cf82f9d
Compare
RomainGuarinoni
force-pushed
the
59-change-group-invitation
branch
from
March 28, 2022 12:35
1c89013
to
e1e7f50
Compare
RomainGuarinoni
force-pushed
the
59-change-group-invitation
branch
from
March 28, 2022 15:44
78fc746
to
15452fb
Compare
RomainGuarinoni
added
enhancement
New feature or request
Long issue
Need a lot of times to implement
labels
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New invitations system
2 types of invitations
MusicianToGroup
: When a musician want to join a group and send an invite to the groupGroupToMusician
: When a group want a musician as a new member and send an invitation to the musicianSchemas
MusicianToGroup
GroupToMusician
Routes for groups
All these routes can be accessed by all the member of the group. Event a member can send, accept or decline an invitation.
GET /groups/{groupId}/invitations/received
Return all the invitation received by the groups
GET /groups/{groupId}/invitations/sent
Return all the invitations sent by the group
POST /groups/{groupId}/invitations
Send a new invitation to a musician. If the invitation already exist, it will updated it if needed
DELETE /groups/{groupId}/invitations/{invitationId}
Delete an invitation that the group have sent to a musician
POST /groups/{groupId}/invitations/{invitationId}/accept
Accept an invitation received by the group
DELETE /groups/{groupId}/invitations/{invitationId}/decline
Decline an invitation received by the group
Routes for profil
GET /profil/invitations/received
Return all the invitation received by the logged musician
GET /profil/invitations/sent
Return all the invitations sent by the logged musician
POST /profil/invitations
Send a new invitation to a group. If the invitation already exist, it will updated it if needed
DELETE /profil/invitations/{invitationId}
Delete an invitation that the logged musician have sent to a musician
POST /profil/invitations/{invitationId}/accept
Accept an invitation received by the logged musician
DELETE /profil/invitations/{invitationId}/decline
Decline an invitation received by the logged musician
New notifications
GroupReceiveInvitationNotification
MusicianJoinedGroupNotification
GroupDeclineInvitationNotification
MusicianDeclineInvitationNotification
Memberships
Now, membership can either be
admin
,lite_admin
ormember
. There is nopending
ordeclined
anymore