Impl: Fallback channel ID #95
Open
+93,016
−93,000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If user was to trigger a build & deploy action without a pull request the action would fail This ensures that if no channel id is present the sha for the commit being used
ChannelId currently polluted with refs/heads/ segment of the git ref we remove it to give a clear and more informative channelId name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Issue: #90
This pull request ensures that a preview channel id is always generated by falling back to the branch name and commit sha
Useful for when when a commit is added directly to the development branch which we don't want to go live but yet wish to see the changes of (especially on solo projects where PRs don't make sense in a lot of cases)
The implementation has been tested on my own fork and works