fix(edge-migrator): add call to migrate to v2 #4983
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Uffizzi Ephemeral Environment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4983 +/- ##
=======================================
Coverage 97.39% 97.39%
=======================================
Files 1191 1192 +1
Lines 41626 41641 +15
=======================================
+ Hits 40543 40558 +15
Misses 1083 1083 ☔ View full report in Codecov by Sentry. |
matthewelwell
commented
Jan 9, 2025
| @@ -81,4 +82,5 @@ def migrate(self): | |||
| ) | |||
| ) | |||
| identity_wrapper.write_identities(iterator_with_prefetch(identities)) | |||
| migrate_project_environments_to_v2(project_id) | |||
There was a problem hiding this comment.
This will need more work since it won't work unless we set the read capacity budget against the project. We should therefore just write the identity overrides directly to the flagsmith_environments_v2 table but this requires a larger refactor of the logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Creating a draft PR for now based on this Crisp chat. This needs more work, but this is a start.
How did you test this code?
Please describe.