fix cran comments

Flavjack · Mar 31, 2022 · 8e68eec · 8e68eec
1 parent 392ba4c
commit 8e68eec
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 6 deletions.
diff --git a/CRAN-SUBMISSION b/CRAN-SUBMISSION
@@ -0,0 +1,3 @@
+Version: 0.5.5
+Date: 2022-03-31 18:40:25 UTC
+SHA: 392ba4c3331d77d731a4429853f30f06083f11bd
diff --git a/NEWS.md b/NEWS.md
@@ -7,6 +7,7 @@
 - Tarpuy: select sheet for field-book sketch
 - Tarpuy: create field-book only with the factor list
 - Tarpuy: column with [] are omitted in the field-book generation
+- CRAN comments: if (class(model) == "lmerMod") => if ( is(model, "lmerMod") 
 
 # inti 0.5.4
 

diff --git a/R/plot_diag.R b/R/plot_diag.R
@@ -17,6 +17,8 @@
 #' 
 #' lm <- aov(stemdw ~ bloque + geno*treat, dt)
 #' 
+#' #lm <- lme4::lmer(stemdw ~ bloque + (1|geno:treat), dt)
+#'  
 #' plot(lm, which = 1)
 #' plot_diag(lm)[3]
 #' 
@@ -38,11 +40,11 @@ plot_diag <- function( model, title = NA) {
 
   title <- if(is.null(title) || is.na(title) ) {""} else {title}
 
-  dt <- if ( class(model) == "lm" || class(model) == "aov" ) {
+  dt <- if ( inherits(model, "lm") || inherits(model, "aov") ) {
 
     ggplot2::fortify(model)
 
-  } else if ( class(model) == "lmerMod" ) {
+  } else if ( inherits(model, "lmerMod") ) {
 
     lme4::fortify.merMod(model)
 

diff --git a/R/utils.R b/R/utils.R
@@ -4,7 +4,3 @@ utils::globalVariables(c(".", ":=", "%>%"))
 #' @export
 dplyr::`%>%`
 
-
-
-
-
diff --git a/man/plot_diag.Rd b/man/plot_diag.Rd
Original file line number	Diff line number	Diff line change
Expand Up		@@ -4,7 +4,3 @@ utils::globalVariables(c(".", ":=", "%>%"))
		#' @export
		dplyr::`%>%`