-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for python 3.11 #771
Conversation
Signed-off-by: Nischay Ram Mamidi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A change in app.in can be accompanied by an update in app.txt, probably.
Of course, we're unsure if 3.8 can use numpy 1.26 ...
Yeah. I think we can push to 1.24.0 instead of 1.25. Since, 1.25 is not supported for Python 3.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also officially document the 3.11 support in setup.py (that's largely a copy/paste action)
Signed-off-by: Nischay Ram Mamidi <[email protected]>
Signed-off-by: Nischay Ram Mamidi <[email protected]>
Signed-off-by: Nischay Ram Mamidi <[email protected]>
Ran pytest manually with all tests passing on Python 3.11
|
I guess we could defer dealing with the .txt cases in #776 as much as possible. But can you tell me the steps you did in the Docker container to install requirements under 3.11? Let's say we include the app.txt update (for numpy using 1.24) in this PR. |
For the docker container, I just checked if the Python version being installed was Python 3.11. From there I just ran pytests in the container using The make file as modified would ensure that 3.11 dependencies are installed. Currently, the |
Okay so if we don't need a bump in numpy then all dependencies in .txt are okay right now for 3.11. Thanks. |
Signed-off-by: Nicolas Höning <[email protected]>
Description
This PR updates the Makefile to add support for Python 3.11. Currently, pip-tools < 7.0 is not supported on Python 3.11+.
Configuring a minimum requirement to install pip-tools >= 7.0 provides allows the setup to support 3.11.
Related Items
Partially related to #748