Proposing some minor changes #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kenji Brameld <[email protected]>
Signed-off-by: Kenji Brameld <[email protected]>
Signed-off-by: Kenji Brameld <[email protected]>
Signed-off-by: Kenji Brameld <[email protected]>
Signed-off-by: Kenji Brameld <[email protected]>
…ments Signed-off-by: Kenji Brameld <[email protected]>
Signed-off-by: Kenji Brameld <[email protected]>
Signed-off-by: Kenji Brameld <[email protected]>
Merged
Flova
requested changes
Sep 1, 2022
Signed-off-by: Kenji Brameld <[email protected]>
…ncies Signed-off-by: Kenji Brameld <[email protected]>
Signed-off-by: Kenji Brameld <[email protected]>
Signed-off-by: Kenji Brameld <[email protected]>
|
@Flova are there some actionables for me here? |
|
Not really, mainly only the API discussion. |
Flova
reviewed
Sep 17, 2022
Signed-off-by: Kenji Brameld <[email protected]>
Signed-off-by: Kenji Brameld <[email protected]>
|
@Flova I think I've addressed everything now. I've also reverted some formatting so the differences are easier to see. |
Flova
reviewed
Sep 30, 2022
|
@ijnek I think everything except for the test case is fine now. |
Signed-off-by: Kenji Brameld <[email protected]>
|
@Flova Should be good now! |
Flova
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Flova
The main change in this PR, is add default parameters for
timeandplane_frame_id.There are also some simplifications that I made with the srv files, and cleaning up of package.xml files