Reset failed state #5175
Reset failed state #5175
Conversation
greenape
added
bug
| exception=exc, | ||
| ) | ||
| q_state_machine.raise_error() | ||
| raise exc |
There was a problem hiding this comment.
Is there a potential for hang here, if a query can reset from elsewhere? This thread throws Exception, some cache service sees it and tries again, this thrown Exception, ect....
There was a problem hiding this comment.
Yes, something to be wary of - should have enough information to avoid that because we arrive in an explicit reset failed state.
| try: | ||
| log = partial(log, table_name=self.fully_qualified_table_name) | ||
| except NotImplementedError: | ||
| pass # Not a storable by default table |
| with con.begin(): | ||
| con.execute("DROP TABLE IF EXISTS {}".format(full_name)) | ||
| q_state_machine.finish_resetting() | ||
| except Exception as exc: |
There was a problem hiding this comment.
This should probably be a BaseException to catch shutdown as well
greenape
force-pushed
the
reset-failed-state
branch
from
2c04534
to
0360181
Compare
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Codecov Report
@@ Coverage Diff @@
## master #5175 +/- ##
==========================================
- Coverage 93.93% 93.90% -0.04%
==========================================
Files 276 276
Lines 10641 10652 +11
Branches 1280 1280
==========================================
+ Hits 9996 10003 +7
- Misses 517 521 +4
Partials 128 128
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Closes #4009
I have:
Description
Description of what this PR does, and what it changes.