Skip to content

Commit

Permalink
Adding support for Acos (#110)
Browse files Browse the repository at this point in the history
* Adding support for Acos

* Float64 not supported, changed to Float32
  • Loading branch information
dstarkenburg authored Dec 8, 2024
1 parent 296a627 commit 4abb65e
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/load.jl
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ function load_node!(tape::Tape, ::OpConfig{:ONNX, :Abs}, args::VarVec, attrs::At
return push_call!(tape, _abs, args[1])
end

function load_node!(tape::Tape, ::OpConfig{:ONNX, :Acos}, args::VarVec, attrs::AttrDict)
return push_call!(tape, _acos, args[1])
end

function load_node!(tape::Tape, nd::NodeProto, backend::Symbol)
args = [tape.c.name2var[name] for name in nd.input]
Expand Down
1 change: 1 addition & 0 deletions src/ops.jl
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ sub(xs...) = .-(xs...)
_sin(x) = sin.(x)
_cos(x) = cos.(x)
_abs(x) = abs.(x)
_acos(x) = acos.(x)
mul(xs...) = .*(xs...)
relu(x) = NNlib.relu.(x)
leakyrelu(x;a = 0.01) = NNlib.leakyrelu.(x,a)
Expand Down
5 changes: 5 additions & 0 deletions src/save.jl
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,11 @@ function save_node!(g::GraphProto, ::OpConfig{:ONNX, typeof(_abs)}, op::Umlaut.C
push!(g.node, nd)
end

function save_node!(g::GraphProto, ::OpConfig{:ONNX, typeof(_acos)}, op::Umlaut.Call)
nd = NodeProto("Acos", op)
push!(g.node, nd)
end

function save_node!(g::GraphProto, ::OpConfig{:ONNX, typeof(*)}, op::Umlaut.Call)
nd = NodeProto(
input=[onnx_name(v) for v in reverse(op.args)],
Expand Down
6 changes: 6 additions & 0 deletions test/saveload.jl
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ import ONNX: NodeProto, ValueInfoProto, AttributeProto, onnx_name
ort_test(ONNX._abs, A)
end

@testset "Acos" begin
# ONNXRunTime has no implementation for Acos(x::Float64), using Float32
A = rand(Float32, 3, 4)
ort_test(ONNX._acos, A)
end

@testset "Gemm" begin
A, B, C = (rand(3, 4), rand(3, 4), rand(3, 3))
ort_test(ONNX.onnx_gemm, A, B')
Expand Down

0 comments on commit 4abb65e

Please sign in to comment.