Merge #934

934: Fix \ for Cholesky r=DhairyaLGandhi a=devmotion This PR fixes #932 and includes the MWE mentioned in the issue. Co-authored-by: David Widmann <[email protected]>
FluxML · Mar 28, 2021 · 4b7e70d · 4b7e70d
2 parents 56f4118 + 71b5be1
commit 4b7e70d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/lib/array.jl b/src/lib/array.jl
@@ -470,7 +470,7 @@ end
   Y, back = Zygote.pullback((U, B)->U \ (U' \ B), A.U, B)
   return Y, function(Ȳ)
     Ā_factors, B̄ = back(Ȳ)
-    return ((uplo=nothing, status=nothing, factors=Ā_factors), B̄)
+    return ((uplo=nothing, info=nothing, factors=Ā_factors), B̄)
   end
 end
 

diff --git a/test/gradcheck.jl b/test/gradcheck.jl
@@ -548,6 +548,12 @@ end
     @test Zygote.pullback(g, X)[2]((factors=LowerTriangular(X),)) ==
       Zygote.pullback(g, X)[2]((factors=Matrix(LowerTriangular(X)),))
     @test_throws PosDefException Zygote.pullback(X -> cholesky(X, check = false), X)[2]((factors=X,))
+
+    # https://github.com/FluxML/Zygote.jl/issues/932
+    @test gradcheck(rand(5, 5), rand(5)) do A, x
+        C = cholesky(Symmetric(A' * A + I))
+        return sum(C \ x) + logdet(C)
+    end
   end
 end