Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark AbstractFFT test broken #1452

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Mark AbstractFFT test broken #1452

merged 1 commit into from
Sep 6, 2023

Conversation

ToucheSir
Copy link
Member

Having to look through every CI job to see if the failures are known is laborious. The Test stdlib gives us a way to automate this, so let's use it.

@gaurav-arya
Copy link

FYI that there isn't a clear timeline for when AbstractFFTs will get its next release, so if you'd like to fix the Zygote CI without waiting on it I'd recommend just merging this, we can always change it back later

@ToucheSir
Copy link
Member Author

Thanks for the heads up. I think this PR is good to go then.

@ToucheSir ToucheSir merged commit 415ec0a into master Sep 6, 2023
11 of 12 checks passed
@ToucheSir ToucheSir deleted the bc/ci-noise branch September 6, 2023 13:45
@ToucheSir ToucheSir restored the bc/ci-noise branch September 6, 2023 13:46
@ToucheSir ToucheSir deleted the bc/ci-noise branch September 6, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants