Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

76-docs-incorporate-tbs-feedback-into-guardrails #77

Merged
merged 5 commits into from
May 8, 2024

Conversation

bzarboni1
Copy link
Contributor

ISSUE

Upon request, the TBS client provided the following feedback regarding the current Guardrails:

“Use Pull Requests or Merge Requests to review and approve changes to the SCM configuration.”

Which assumes you have an Infra as code approach to the management of your SCM. I would recommend changing that to something like “use documented processes to review and approve changes to the SCM configuration” because you will still have folks who clickops things.

Also there might be a place for Plan for Continuity - Canada.ca especially for SaaS SCM’s you should have a third party back up solution in place (ex. daily S3 backups)


Additionally, some ITSG Control coverage is missing from the Guardrails docs for the controls:

AC-2(3), AC-2(4), AC-6(9), AC-8, AC-9, AC-9(3), AC-12, AC-16(2), AC-17(1), AC-17(2), AC-17(100), 
IA-2(11), IA-5(6), IA-5(7), IA-8, IA-8(100), IA-9, IA-9(1), IA-9(2), 
SC-8, SC-8(1), 
SI-10, SI-12, SI-4(5), SI-4(7)

After incorporating the above controls into the docs, the following will not be implemented / need to be added to the Risk register:

- AC-8, AC-9, AC-9(3), AC-12,
- AC-17(100),
- IA-9, IA-9(1), IA-9(2),
- SI-12

@bzarboni1 bzarboni1 self-assigned this Apr 24, 2024
Copy link

@maxneuvians maxneuvians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for the changes! Well done!

jpound
jpound previously approved these changes May 7, 2024
@bzarboni1 bzarboni1 merged commit 1d99657 into main May 8, 2024
3 checks passed
@bzarboni1 bzarboni1 deleted the 76-docs-incorporate-tbs-feedback-into-guardrails branch May 8, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants