Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add h2o cve #2
base: master
Are you sure you want to change the base?
Add h2o cve #2
Changes from all commits
7336e67
d1ab6b2
c4e07c0
439d55d
1a8c4f2
0bf53fd
90c3578
54eea77
8675655
cd708a5
9228e5e
eb47ebe
d9f1113
5db463b
b18d3ee
4519c28
86d82b5
be1fadc
597a7d3
1adb6e3
65d4fd9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls add how long it takes us to find. Such as:
On our test cluster, given the original seed, it takes about xxx minutes to reproduce the bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please specify a duration (upper bound on what it would take to find, say on demo).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok haven't found the bug from scratch yet (ran target shortly and verified crash repro) but will update when it is found
Large diffs are not rendered by default.