Parameterize Mayhem URL to ensure mAPI CLI matches Mayhem platform #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note to self: Will probably want to update the |
ethan42
reviewed
May 2, 2024
src/main.ts
Outdated
| @@ -21,7 +21,7 @@ async function mapiCLI(): Promise<string> { | |||
| } | |||
|
|
|||
| // Get latest version from API | |||
| let cliVersion = 'latest' | |||
| // let cliVersion = 'latest' | |||
There was a problem hiding this comment.
that'd work if multiple revisions were available for each instance. (there aren't)
what if you made a mayhem-url parameter instead and parameterized the string on Line 45?
|
Actually URL needs to be updated here as well |
This is resolved with 57e16de. |
ethan42
approved these changes
May 2, 2024
|
👍 please update the PR title and description before merging + fix action errors |
xansec
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.