Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortened new() expressions in several places #461

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Shortened new() expressions in several places #461

merged 1 commit into from
Sep 26, 2023

Conversation

Lehonti
Copy link
Contributor

@Lehonti Lehonti commented Sep 26, 2023 •
edited
Loading

The purpose is twofold: being more concise and reduce repetition.

Also, improved null checks in Equals methods of SourceSpan

@ForNeVeR ForNeVeR self-requested a review September 26, 2023 20:09
@ForNeVeR ForNeVeR self-assigned this Sep 26, 2023
ForNeVeR
ForNeVeR approved these changes Sep 26, 2023
View reviewed changes
Copy link
Owner

@ForNeVeR ForNeVeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ForNeVeR ForNeVeR merged commit 725991c into ForNeVeR:master Sep 26, 2023
7 checks passed
@Lehonti Lehonti deleted the improvement1 branch September 26, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForNeVeR ForNeVeR ForNeVeR approved these changes

Assignees

@ForNeVeR ForNeVeR

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lehonti @ForNeVeR