Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extracted some logic from FractionAtom.CreateBoxCore into its own methods #469

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Extracted some logic from FractionAtom.CreateBoxCore into its own methods #469

merged 2 commits into from
Sep 29, 2023

Conversation

Lehonti
Copy link
Contributor

@Lehonti Lehonti commented Sep 28, 2023 •
edited
Loading

I think the original method is long and chaotic. Hopefully this can help improve it, even if it's not yet perfect

ForNeVeR
ForNeVeR approved these changes Sep 29, 2023
View reviewed changes
Copy link
Owner

@ForNeVeR ForNeVeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ForNeVeR ForNeVeR merged commit 0c9cbe6 into ForNeVeR:master Sep 29, 2023
4 checks passed
@Lehonti Lehonti deleted the improvement3 branch September 29, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForNeVeR ForNeVeR ForNeVeR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lehonti @ForNeVeR