feat: credential detail page #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puria
reviewed
Feb 19, 2024
Comment on lines
60
to
62
| <ion-button on:click={stopScan} on:keydown={stopScan} aria-hidden fill="clear"> | ||
| <ion-icon icon={close}></ion-icon> | ||
| </button> | ||
| </ion-button> |
There was a problem hiding this comment.
Why did we go back? Is something missing from the implementation on the components? Wouldn't it be better to implement it there instead?
There was a problem hiding this comment.
Comment on lines
20
to
26
| const serviceSchema = z.object({ | ||
| id: z.string(), | ||
| relying_party: z.string().url(), | ||
| issuer: z.string().url(), | ||
| authorization_server: z.string().url() | ||
| }); | ||
|
|
Comment on lines
68
to
73
| //todo: validate service urls | ||
| if (type == 'service') { | ||
| return { result: 'ok', data: { type, service: parsedValue as Service } }; | ||
| } else { | ||
| return { result: 'ok', data: { type, credential: parsedValue as Credential } }; | ||
| } |
There was a problem hiding this comment.
This should come from the credential-issuer/.well-known
There was a problem hiding this comment.
can you explalin me better?
puria
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.