Save data to standard directory #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nichollsh Could you have a look at this PR and let me know what you think? |
|
FYI, Harrison is on vacation this week. |
|
Ah, good to know, seems like Laurent as well. I was wondering why it was so quiet on all my PRs 😅 |
|
I can see that I can get some reviewed during the week, but I will probably not be able to do all of them. |
|
No worries, there is no rush! |
lsoucasse
approved these changes
Aug 19, 2024
lsoucasse
pushed a commit
that referenced
this pull request
Sep 24, 2024
* Set standard directory for data * Add CLI command, `janus env` to show env variables/data locations * Update documentation * Print destination * Uppercase variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a standard data directory for JANUS. You can still set
FWL_DATA, but instead of crashing, JANUS will use a default directory instead.I single-sourced the FWL data directory to
janus.utils.data.FWL_DATA_DIR, so you can dofrom janus.utils.data import FWL_DATA_DIR. This avoids checking the env var in multiple places.I also added a small CLI command to check the current data locations:
Closes #36