Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outgassing handled by CALLIOPE and other minor additions #176

Merged
merged 19 commits into from
Sep 10, 2024
Merged

Conversation

nichollsh
Copy link
Contributor

@nichollsh nichollsh marked this pull request as ready for review September 9, 2024 17:05
@nichollsh
Copy link
Contributor Author

Some weird behaviours with the GitHub actions not finding the calliope package. Will investigate, but removed review requests for now

@lsoucasse
Copy link
Member

Hi @nichollsh, there is at list one mistake in the pyproject.toml file of Caliope that can explain not finding the paths:
Replacepackage-dir = {"proteus" = "src/calliope" }
By package-dir = {"calliope" = "src/calliope" }

@nichollsh nichollsh requested a review from lsoucasse September 10, 2024 08:26
@nichollsh
Copy link
Contributor Author

Thanks for the suggestion, @lsoucasse. This has worked, and the PR is now ready for review.

pyproject.toml Outdated Show resolved Hide resolved
Co-authored-by: Laurent Soucasse <[email protected]>
Copy link
Member

@lsoucasse lsoucasse Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All plots in examples/dummy look the same. Could you confirm they are different?
Same comment for examples/earth_demo pdf files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They probably are indeed the same as before, since this PR doesn't change any of the physics involved in running the simulations. The only changes related to that are ensuring that PROTEUS doesn't try to plot the atmosphere fluxes and structure when using the dummy model.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did re-run the examples to make sure that they were generated with a recent version of the code, although this would be better solved by #165

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum... the csv output displays small differences. So I guess it is fine to upload the new plots.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does - that's interesting. The differences are quite small, but I think this is something we should keep in mind, especially as we get closer to setting up proper tests for PROTEUS.

@nichollsh
Copy link
Contributor Author

Thanks!

@nichollsh nichollsh merged commit 0043ff5 into main Sep 10, 2024
3 checks passed
@nichollsh nichollsh deleted the calliope branch September 10, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post-process model outputs with high resolution spectral file Remove surface_gases.py and import CALLIOPE
2 participants