-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outgassing handled by CALLIOPE and other minor additions #176
Conversation
Some weird behaviours with the GitHub actions not finding the calliope package. Will investigate, but removed review requests for now |
Hi @nichollsh, there is at list one mistake in the pyproject.toml file of Caliope that can explain not finding the paths: |
Thanks for the suggestion, @lsoucasse. This has worked, and the PR is now ready for review. |
Co-authored-by: Laurent Soucasse <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All plots in examples/dummy look the same. Could you confirm they are different?
Same comment for examples/earth_demo pdf files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They probably are indeed the same as before, since this PR doesn't change any of the physics involved in running the simulations. The only changes related to that are ensuring that PROTEUS doesn't try to plot the atmosphere fluxes and structure when using the dummy model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did re-run the examples to make sure that they were generated with a recent version of the code, although this would be better solved by #165
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum... the csv output displays small differences. So I guess it is fine to upload the new plots.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does - that's interesting. The differences are quite small, but I think this is something we should keep in mind, especially as we get closer to setting up proper tests for PROTEUS.
Thanks! |
surface_gases.py
. Closes Removesurface_gases.py
and import CALLIOPE #174tools/PostprocHighres.jl
) for post-processing completed simulations with a high resolution spectral file using more complete opacities. Closes Post-process model outputs with high resolution spectral file #175