Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thru filter overhaul #232

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Commits on Aug 6, 2021

  1. thru filter overhaul

    * resolves FortySevenEffects#40 with franky47's proposed thru filter overhaul
    * removes thru filter modes
    * adds thru filter callback
    * adds thru map callback
    * old thru filter unit tests have been replicated with filter callbacks
    * does not yet include documentation changes
    
    I believe this implements the latest proposal for FortySevenEffects#40 and exercises
    everything necessary in the unit tests, including the immutability of
    `mMessage` after a thru map callback has modified the outgoing message.
    
    The thru filter callbacks in the unit tests are not suitable for copying
    and pasting by end-users due to the difference in the MIDI namespace
    when setup via the unit tests vs via `MIDI_CREATE_DEFAULT_INSTANCE()`.
    
    If the changes here are deemed suitable, I'll work on documentation.
    hyperbolist committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    0020607 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    08f6f53 View commit details
    Browse the repository at this point in the history
  3. chore: Allow copying Messages

    This is ground work for the `map` Thru function
    in PR FortySevenEffects#232.
    franky47 authored and hyperbolist committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    2ae9d9e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6bdb707 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. chore: Add example

    franky47 committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    2fec41e View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. feat: Export type definitions when using macros

    Types have names prepended by the port name
    (defaults to `MIDI`), to allow multi-port applications.
    
    This allows referencing those types elsewhere in the
    application, without re-writing the template arguments,
    and simplifies referencing the underlying Message type,
    for SoftThru `filter`/`map`function definitions.
    
    Proposition & discussion:
    FortySevenEffects#232 (comment)
    franky47 committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    7bb96f9 View commit details
    Browse the repository at this point in the history