-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thru filter overhaul #232
Open
hyperbolist
wants to merge
6
commits into
FortySevenEffects:master
Choose a base branch
from
hyperbolist:thru-filter-overhaul
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
thru filter overhaul #232
hyperbolist
wants to merge
6
commits into
FortySevenEffects:master
from
hyperbolist:thru-filter-overhaul
Commits on Aug 6, 2021
-
* resolves FortySevenEffects#40 with franky47's proposed thru filter overhaul * removes thru filter modes * adds thru filter callback * adds thru map callback * old thru filter unit tests have been replicated with filter callbacks * does not yet include documentation changes I believe this implements the latest proposal for FortySevenEffects#40 and exercises everything necessary in the unit tests, including the immutability of `mMessage` after a thru map callback has modified the outgoing message. The thru filter callbacks in the unit tests are not suitable for copying and pasting by end-users due to the difference in the MIDI namespace when setup via the unit tests vs via `MIDI_CREATE_DEFAULT_INSTANCE()`. If the changes here are deemed suitable, I'll work on documentation.
Configuration menu - View commit details
-
Copy full SHA for 0020607 - Browse repository at this point
Copy the full SHA 0020607View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08f6f53 - Browse repository at this point
Copy the full SHA 08f6f53View commit details -
This is ground work for the `map` Thru function in PR FortySevenEffects#232.
Configuration menu - View commit details
-
Copy full SHA for 2ae9d9e - Browse repository at this point
Copy the full SHA 2ae9d9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bdb707 - Browse repository at this point
Copy the full SHA 6bdb707View commit details
Commits on Aug 31, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 2fec41e - Browse repository at this point
Copy the full SHA 2fec41eView commit details
Commits on Sep 2, 2021
-
feat: Export type definitions when using macros
Types have names prepended by the port name (defaults to `MIDI`), to allow multi-port applications. This allows referencing those types elsewhere in the application, without re-writing the template arguments, and simplifies referencing the underlying Message type, for SoftThru `filter`/`map`function definitions. Proposition & discussion: FortySevenEffects#232 (comment)
Configuration menu - View commit details
-
Copy full SHA for 7bb96f9 - Browse repository at this point
Copy the full SHA 7bb96f9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.