Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for state-specific, optional holidays #433

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

naveensingh
Copy link
Member

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Modified the holiday generator to generate public, state-specific and optional holidays.
  • Updated holiday UID format to reduce duplication and potential in-app uses.
  • Added chooser dialog with 'Public', 'Regional' and 'Other' holiday options.

Fixes the following issue(s)

Acknowledgement

 - Modified the holiday generator to generate public, state-specific and optional holidays.
 - Updated holiday UID format to reduce duplication and potential in-app uses.
 - Added chooser dialog with 'Public', 'Regional' and 'Other' holiday options.
@naveensingh naveensingh merged commit de2b606 into master Jan 22, 2025
2 of 4 checks passed
@naveensingh naveensingh deleted the add_optional_holidays branch January 22, 2025 21:43
@naveensingh naveensingh mentioned this pull request Jan 22, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Canadian holiday Some (regional) Holidays for Germany missing
1 participant