Skip to content

Commit

Permalink
Give up on getting Coverage comment in pull request itself.
Browse files Browse the repository at this point in the history
The plugin does not have a way of setting the base sha for the `workflow_run` case and so won't get the proper diffs.
Instead put it inline in the `pull_request` workflow (which does not have access to add PR comments) and just write to job summary.
  • Loading branch information
MMcM committed Feb 14, 2025
1 parent ef30f4c commit a458fbd
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 52 deletions.
17 changes: 8 additions & 9 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -139,13 +139,12 @@ jobs:
name: coverage-report
path: |
${{ github.workspace }}/.out/reports/jacoco/codeCoverageReport/
- name: Save Pull Request Number
run: echo ${{ github.event.number }} >.pr_number
- name: Upload Pull Request Number
uses: actions/[email protected]
- name: Add Coverage Summary
uses: madrapps/jacoco-report@e4bbaf00a0b8920cb86a448ae3ec0fc6f6bfeacc
with:
name: pull-request-number
path: |
${{ github.workspace }}/.pr_number
include-hidden-files: true
retention-days: 1
paths: |
${{ github.workspace }}/.out/reports/jacoco/codeCoverageReport/codeCoverageReport.xml
token: ${{ secrets.GITHUB_TOKEN }}
comment-type: summary
min-coverage-overall: 75
min-coverage-changed-files: 80
43 changes: 0 additions & 43 deletions .github/workflows/pull_request_comments.yml

This file was deleted.

0 comments on commit a458fbd

Please sign in to comment.