Run mixed mode tests in a workflow, and publish results to release notes #3166
+304
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When debugging the tests, if you stop it sends SIGKILL, which kills the test process, but not any of the child processes. This means that when you restart the tests they'll fail, because the ports are taken. We could have it dynamically generate ports, but that would most likely lead to developers having hundreds of servers running. Instead, this code, at startup will find all running servers and kill them.
This allows running the mixed-mode tests against a bunch of versions. It is currently set to the 50 most up-to-date versions (based on version ordering, not publish date). That being said, builds older than 4.0.559.0 did not publish a server, so we can't test against anything older than that. I chose the 50 pretty arbitrarily, we can adjust as time goes on. I wanted to also check the `Build-Date` but it appears that is not getting correctly filled in.
This will allow us to parse the results of the various versions, and present them.
…ase notes This should, at some point, be connected to the release workflow, but I'm not doing that, and I think it might always be good to be able to re-run this independently of doing a release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #3154 and adds the workflow to run the tests, and the code to add it to the release notes.
This also temporarily includes #3152, I will have to rebase....