Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP File Concept #2100

Draft
wants to merge 95 commits into
base: main
Choose a base branch
from
Draft

WIP File Concept #2100

wants to merge 95 commits into from

Conversation

maximiliankaul
Copy link
Contributor

WIP implementation of (Python) file concepts.

@maximiliankaul maximiliankaul added python concepts Related to CPG concepts module labels Mar 3, 2025
@maximiliankaul maximiliankaul self-assigned this Mar 3, 2025
@@ -0,0 +1,15 @@
- Neo4j / console
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably left over

// what do we want to have here? binary? text? r+ vs w+? create mode? ...?
}

class File(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing doc

APPEND,
UNKNOWN,

// what do we want to have here? binary? text? r+ vs w+? create mode? ...?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we definitely need the chmod flags in some form, not sure where

class FileChangePermissions(
underlyingNode: Node,
override val concept: File,
val newPermissions: String,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a enum or similar for the permissions?

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 62.44131% with 80 lines in your changes missing coverage. Please review.

Project coverage is 78.41%. Comparing base (5c47ed5) to head (7c629fc).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...sses/concepts/file/python/PythonFileConceptPass.kt 52.51% 42 Missing and 24 partials ⚠️
...hofer/aisec/cpg/graph/concepts/file/FileBuilder.kt 78.57% 9 Missing ⚠️
...e/fraunhofer/aisec/cpg/graph/concepts/file/File.kt 86.20% 4 Missing ⚠️
...e/fraunhofer/aisec/cpg/graph/concepts/Operation.kt 0.00% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (62.44%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
Files with missing lines Coverage Δ
...kotlin/de/fraunhofer/aisec/cpg/graph/Extensions.kt 55.97% <ø> (ø)
...n/de/fraunhofer/aisec/cpg_vis_neo4j/Application.kt 57.63% <100.00%> (+0.42%) ⬆️
...e/fraunhofer/aisec/cpg/graph/concepts/Operation.kt 83.33% <0.00%> (-16.67%) ⬇️
...e/fraunhofer/aisec/cpg/graph/concepts/file/File.kt 86.20% <86.20%> (ø)
...hofer/aisec/cpg/graph/concepts/file/FileBuilder.kt 78.57% <78.57%> (ø)
...sses/concepts/file/python/PythonFileConceptPass.kt 52.51% <52.51%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concepts Related to CPG concepts module python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants