Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically register and synchronize AASs and submodels in FA³ST Service with Registry #524

Closed
wants to merge 33 commits into from
Closed

Automatically register and synchronize AASs and submodels in FA³ST Service with Registry #524

wants to merge 33 commits into from

Conversation

arabbitplays
Copy link
Contributor

@arabbitplays arabbitplays commented Aug 4, 2023 •
edited
Loading

Synchronization of asset administration shells and submodels with fa³st registry.
https://github.com/FraunhoferIOSB/FAAAST-Registry

Oschdi and others added 29 commits July 11, 2023 20:00
Registration setup
2686816
Using descriptor from given model
5c74af9
Refactoring und Exception handling
4d49105
Exception Handling
72fb687
Merge remote-tracking branch 'origin/feature/registrySync' into featu…
7c56992 
…re/registrySync

# Conflicts:
#	starter/src/main/java/de/fraunhofer/iosb/ilt/faaast/service/starter/App.java
Unregistration
7456dd0
Registry URL in config
419077b
Move registration in Service.java
e276d42
First mocked event
d7db9ef
Aas update calls to registry
c6ba3ea
Implementation of FaaastRegistryHandler
e7a0755
Mocking of Messagebus and Persistence
e18d8e6
First working tests but errors are not found
2ed3d78
Cleanup
ba376a4
Tests can fail now
542f38a
Add initialization test
153f947
Merge branch 'main' into feature/registrySync
9665fc4 
# Conflicts:
#	core/src/main/java/de/fraunhofer/iosb/ilt/faaast/service/config/CoreConfig.java
#	starter/src/main/java/de/fraunhofer/iosb/ilt/faaast/service/starter/App.java
Unregistration test, testing of bodies and java doc
7c29992
Clean Up
7d38519
Clean Up and test fix
07c85dd
ConfigTest fixes
54387a1
Clean up
69bccdd
Clean up
a627fd7
Synchronisation of submodels
5336ce5
Synchronisation of submodels when aas is added
54238a2
Clean up and test fixes
bd82b05
Clean up and docs
8374b06
Submodel Tests
699a0fe
@arabbitplays
Merge branch 'main' into feature/registrySync
044097e
@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

77.4% 77.4% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@fvolz
code review
829276b
@fvolz
more review
fba72c9 
we probably need to discuss how to handle exceptions for registration
@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

80.7% 80.7% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

17 New issues
0 Security Hotspots
80.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mjacoby mjacoby marked this pull request as draft January 9, 2024 09:21
@mjacoby mjacoby changed the title Feature/registry syncronisation Automatically register and synchronize AASs and submodels in FA³ST Service with Registry Jan 9, 2024
@mjacoby
Copy link
Member

mjacoby commented Jul 17, 2024

superseeded by #828

@mjacoby mjacoby closed this Jul 17, 2024
@mjacoby mjacoby deleted the feature/registrySync branch July 17, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arabbitplays @mjacoby @fvolz