Do not use external zipios #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per comment on FreeCAD/FreeCAD#13676 (comment)
...but leave the -dev package to build the zipios++ bundled with the FreeCAD sources
|
@chennes would you mind reviewing and merging? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per comment on FreeCAD/FreeCAD#13676 (comment) and FreeCAD/FreeCAD#13676 (comment)
In summary, the .snap package was using the Debian package version of zipios, which seems to contain a bug when used in FreeCAD to read thumbnails. This change reverts the snap package to use the bundled zipios sources built with FreeCAD.
I've also built a local .snap package from this branch for testing purposes, which fixes the issue on my system. Available under the "Artifacts" section on the workflow run summary page at: https://github.com/furgo16/FreeCAD-snap/actions/runs/12312936300
Fixes FreeCAD/FreeCAD#13676