RE: Code cleanup #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve PEP8 warnings. Signed-off-by: Stephen Finucane <[email protected]>
Per PEP257, it is not recommended that signatures are given in docstrings as they may be obtained via introspection. Instead, use the docstring format suggested by Google Python Style Guide. Signed-off-by: Stephen Finucane <[email protected]>
Rather than having a function to "make" Message, do the required actions in the '__init__' function. This includes minor changes to the unit tests per this change. Signed-off-by: Stephen Finucane <[email protected]>
Resolve PyLint issues: * Invalid variables names * Missing docstrings * Badly wrapped lines Signed-off-by: Stephen Finucane <[email protected]>
This package is deprecated and is not available in Python 3. Remove the tests. In addition, resolve some immediate PyLint warnings. Signed-off-by: Stephen Finucane <[email protected]>
Allow user to provide mbox path to 'main' function as an argument to the executable. Signed-off-by: Stephen Finucane <[email protected]>
|
@stephenfin I was also planning to look into Python 3 support. Would you have any suggestions as to which parts of the tests suite are worth expanding (if you still remember, one year later)? Thanks! |
I'm afraid not - it's been a while. I imagine lots of test cases wouldn't go astray, however. |
|
@stephenfin True, thanks for the response! By the way, it looks like your PR was mostly PY3 compatible, apart from a single |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of the original PR akuchling#3 by @stephenfin,
Making this a separate PR to make sure that unit tests in Travis CI pass and to rebase on top of PR #1.