add custom errors compatible with std #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oroulet
force-pushed
the
errors
branch
2 times, most recently
from
c75d961 to
b842997
Compare
einarmo
reviewed
Jan 2, 2025
svanharmelen
requested changes
Jan 4, 2025
to be used for internal code and not abuse StatusCode errors from protocol Co-authored-by: Sander van Harmelen <[email protected]>
thanks. My last commit was obviosuly done far too fast. But my main question/proposition with that MR is to create that enum for std compatible errors. I was suprised they did not exist in current code base. I thought maybe I was missing something.. |
oroulet
commented
Jan 5, 2025
svanharmelen
requested changes
Jan 5, 2025
Co-authored-by: Sander van Harmelen <[email protected]>
Co-authored-by: Sander van Harmelen <[email protected]>
|
@svanharmelen for some reason, you still have some "change request" preventing the merge But I cannot see for what... |
|
GitHub doesn't automatically dismiss a review when changes are requested (even if those changes are implemented). So once your done (which I can see your are) I can/should take another look and approve the changes if all is good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be used for internal code and not abuse
StatusCode errors from protocol