Workaround for browser future not being Send #23
Merged
+21
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
einarmo
force-pushed
the
fix-browser-sendness
branch
from
a24d995 to
283fdc0
Compare
|
great! that works! |
oroulet
approved these changes
Jan 8, 2025
This is incredibly hard to diagnose, because the compiler error is useless.
oroulet
force-pushed
the
fix-browser-sendness
branch
from
283fdc0 to
36bdd25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is incredibly hard to diagnose, because the compiler error is useless.
I hate having to box a future in such a critical location, but I can't find a way around it. If someone wants to spend a few hours banging their head against rustc issue 100013, be my guest.
The bug in question is rust-lang/rust#100013. I have a vague intuition that it may be able to dodge this issue by making
UARequesta generic trait instead of using a GAT. It may be worth trying, as it won't necessarily break usecases.