Relax loading XML values using FromValue #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
einarmo
force-pushed
the
relax-from-value-load
branch
from
4290603 to
abaa6cc
Compare
All the ones we currently use it for implement Default, so we can just use unwrap_or_defualt. This handles the case of empty strings, and is probably fine for other types. It's a little weird for numbers, but 0 is a pretty reasonable way to interpret an empty <Int></Int> tag.
einarmo
force-pushed
the
relax-from-value-load
branch
from
abaa6cc to
0e00e1d
Compare
oroulet
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the ones we currently use it for implement Default, so we can just use unwrap_or_defualt. This handles the case of empty strings, and is probably fine for other types. It's a little weird for numbers, but 0 is a pretty reasonable way to interpret an empty tag.