Xml encoding #47
Merged
Xml encoding #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Further work is going to need derive macros to be implemented.
This is a major rewrite of XML parsing, adding support for XML serialization, and bringing it up to the same level as JSON and binary. I also fixed a few bugs I hit on in a few places. There are still some things remaining: - Unions - XML in binary/json encoded extension objects. - Proper support for the XmlElement variant (currently it doesn't work properly for XML). Note that this variant type is deprecated. This PR is already way too big. There was no real way to make it smaller, since once you start replacing FromXml there's no way to stop while still having the library compile.
einarmo
force-pushed
the
xml-encoding
branch
from
7840940 to
43314d5
Compare
svanharmelen
approved these changes
Feb 26, 2025
|
Thanks for the review! I hope and believe this will be the last PR of this size, (excluding any more generated code in the future). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major rewrite of XML parsing, adding support for XML serialization, and bringing it up to the same level as JSON and binary. I also fixed a few bugs I hit on in a few places. There are still some things remaining:
This PR is already way too big. There was no real way to make it smaller, since once you start replacing FromXml there's no way to stop while still having the library compile.
The PR is split into a few smaller commits, that incrementally add features, at least as much as was possible while still having each commit compile. The line count may be a little misleading, since a fair bit of it is generated, but this is a big PR, just because there are so many changes.
I want to, in the future, use
quick-xmls serde feature to replaceroxmltreeentirely, but this is currently not possible, as there is no way to capture raw XML, which we need to in order to defer loading of values for later, onceContextis available.We may also want to create an attribute-macro to automatically derive all the different encoding macros depending on input type, since just the derives are getting a bit verbose.